Replace validUpdateChannel anonymous namespace function with validUpdateChannels...

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

diff --git a/src/libsync/configfile.cpp b/src/libsync/configfile.cpp
index 1e7dc3ed61741f8e91902179f3b401be79198837..82ac801dba3f14b5140f0f3d0dc7ce370d6d0182 100644 (file)
--- a/src/libsync/configfile.cpp
+++ b/src/libsync/configfile.cpp
@@ -105,10 +105,7 @@ static constexpr char moveToTrashC[] = "moveToTrash";
 static constexpr char certPath[] = "http_certificatePath";
 static constexpr char certPasswd[] = "http_certificatePasswd";
 
-bool validUpdateChannel(const QString &channel)
-{
-    return channel == QStringLiteral("stable") || channel == QStringLiteral("beta");
-}
+static const QSet validUpdateChannels { QStringLiteral("stable"), QStringLiteral("beta") };
 }
 
 namespace OCC {
@@ -698,7 +695,7 @@ QString ConfigFile::updateChannel() const
 
     QSettings settings(configFile(), QSettings::IniFormat);
     const auto channel = settings.value(QLatin1String(updateChannelC), defaultUpdateChannel).toString();
-    if (!validUpdateChannel(channel)) {
+    if (!validUpdateChannels.contains(channel)) {
         qCWarning(lcConfigFile()) << "Received invalid update channel from confog:"
                                   << channel
                                   << "defaulting to:"
@@ -711,7 +708,7 @@ QString ConfigFile::updateChannel() const
 
 void ConfigFile::setUpdateChannel(const QString &channel)
 {
-    if (!validUpdateChannel(channel)) {
+    if (!validUpdateChannels.contains(channel)) {
         qCWarning(lcConfigFile()) << "Received invalid update channel:"
                                   << channel
                                   << "can only accept 'stable' or 'beta'. Ignoring.";