close

diff --git a/doc/bugs/windows__58___plenty_of_unit_tests_fail_aftr_8.20211028.mdwn b/doc/bugs/windows__58___plenty_of_unit_tests_fail_aftr_8.20211028.mdwn
index 96e30a9fa9949cc905513e97a313958fe8fd28a6..f6f6c32e6aa9b2ff06e1a008caa6486c3e2df168 100644 (file)
--- a/doc/bugs/windows__58___plenty_of_unit_tests_fail_aftr_8.20211028.mdwn
+++ b/doc/bugs/windows__58___plenty_of_unit_tests_fail_aftr_8.20211028.mdwn
@@ -1282,3 +1282,6 @@ development on master. A fine piece of software it definitely is.
 
 [[!meta title="plenty of unit tests fail after 8.20211028"]]
 [[!meta author=jkniiv]]
+
+> I expect that [[!commit 837025b14f523f9180f82d0cced1e53a8a9b94de]] fixes
+> this. [[done]] --[[Joey]]

diff --git a/doc/todo/git_smudge_clean_interface_suboptiomal.mdwn b/doc/todo/git_smudge_clean_interface_suboptiomal.mdwn
index f7d35f3af4eff38560af8a5fd7124d93d15cf58a..c807659dcc58a6bf87bca20b01bed1866f70ff1f 100644 (file)
--- a/doc/todo/git_smudge_clean_interface_suboptiomal.mdwn
+++ b/doc/todo/git_smudge_clean_interface_suboptiomal.mdwn
@@ -115,3 +115,41 @@ The best fix would be to improve git's smudge/clean interface:
 
 * Allow clean filter to read work tree files itself, to avoid overhead of
   sending huge files through a pipe.
+
+----
+
+## benchmarking
+
+* git add of 1000 small files (adding to git repository not annex)
+       - no git-annex: 0.2s
+       - git-annex with smudge --clean: 63.3s
+       - git-annex with filter-process enabled: 2.3s
+       This is the obvious win case for filter-process. However, people
+       rarely add large numbers of small files to a git repository at the
+       same time.
+* git add of 1000 small files (adding to annex)
+       - git-annex with smudge --clean: 120.9s
+       - git-annex with filter-process enabled: 28.2s
+       - (git-annex add of 1000 small files, for comparison): 17.2s
+       This is a decent win for filter-process, and would also be somewhat
+       of a win when adding larger files to the annex with git add, though
+       less so because hashing overhead would dominate that.
+* git add of 1 gb file (adding to annex)
+       - git-annex with smudge --clean: 14.5s
+       - git-annex with filter-process enabled: 15.4s
+       This was a surprising result! With filter-process, git feeds
+       the file to git-annex via a pipe, and git-annex also reads it from
+       disk. Probably disk caching helped a lot to avoid this taking
+       longer. (`free` says the disk cache has 1.7gb available)
+       That double read could be avoided with some work to make
+       git-annex hash what it receives from the pipe. I also expected
+       the piping to add more overhead than it seems to have.
+* git checkout of branch with 1000 small annexed files
+       - no git-annex (checking out annex pointer files): 0.1s
+       - git-annex with smudge: 83.4s
+       - git-annex with filter-process: 16.0s ()
+       With filter-process, the actual checkout takes under a second,
+       then the post-checkout hook which populates the annexed files
+       and restages them in git. The restaging does not
+       use filter-process currently. The number in parens is with
+       git-annex modified so the restaging does use filter-process.