Enable "trivial" modernize clang-tidy checks

This is a bunch of modernize checks which we don't hit at all. This is
an easy win and also make sure those old constructs won't creep up
behind our back.

Note that some of them won't trigger until we bump our C++ baseline
standard to C++17. But I'd say that's OK, that'll force our hand to do
those C++17 related cleanups when the time comes.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>

diff --git a/.clang-tidy b/.clang-tidy
index 4c03e129deebd4d0153fae4689578e237169c9e0..cda2510ad1946a949b36f3a55b136032ed05e595 100644 (file)
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -1,16 +1,23 @@
 Checks: '-*,
     cppcoreguidelines-init-variables,
+    modernize-avoid-bind,
+    modernize-concat-nested-namespaces,
+    modernize-deprecated-ios-base-aliases,
     modernize-make-*,
     modernize-raw-string-literal,
     modernize-redundant-void-arg,
     modernize-replace-*,
     modernize-return-braced-init-list,
     modernize-shrink-to-fit,
+    modernize-unary-static-assert,
     modernize-use-auto,
     modernize-use-bool-literals,
     modernize-use-default-member-init,
     modernize-use-emplace,
+    modernize-use-equals-delete,
+    modernize-use-nodiscard,
     modernize-use-noexcept,
+    modernize-user-override,
     modernize-use-transparent-functors,
     modernize-use-uncaught-exceptions,
 '