comment

diff --git a/Remote/Adb.hs b/Remote/Adb.hs
index 060366a9fb71bce77ffa531e43d6ccb4be9cb089..580a640fc538ac5faeb111553b95b33ff7cadec8 100644 (file)
--- a/Remote/Adb.hs
+++ b/Remote/Adb.hs
@@ -202,6 +202,7 @@ retrieve' serial src dest =
                showOutput -- make way for adb pull output
                liftIO $ boolSystem "adb" $ mkAdbCommand serial
                        [ Param "pull"
+                       , Param "-a"
                        , File $ fromAndroidPath src
                        , File dest
                        ]

diff --git a/doc/bugs/adb_pull_does_not_preserve_timestamp/comment_1_b695826d1f948249b496c055b4d745df._comment b/doc/bugs/adb_pull_does_not_preserve_timestamp/comment_1_b695826d1f948249b496c055b4d745df._comment
new file mode 100644 (file)
index 0000000..49c8924
--- /dev/null
+++ b/doc/bugs/adb_pull_does_not_preserve_timestamp/comment_1_b695826d1f948249b496c055b4d745df._comment
@@ -0,0 +1,17 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 1"""
+ date="2022-01-03T17:48:38Z"
+ content="""
+Git does not preserve timestamps. So this is kind of out of scope.
+
+While git-annex will sometimes preserve timestamps when it's easy to do so,
+there are no guarantees. Most special remotes do not preserve any
+timestamps in either direction.
+
+It might be that `adb pull -a` would fix this. But that also preserves
+the permissions, and pulling in random permissions for annex object files
+could lead to arbitrary breakage (imagine a suid executable for example).
+So it would need to clear the permissions. The complexity does not seem
+worth trying to support a thing that is generally out of scope.
+"""]]