[PATCH libaio 27/28] harness: Print better error messages on error conditions in...
authorGuillem Jover <guillem@hadrons.org>
Wed, 21 Aug 2019 03:29:50 +0000 (05:29 +0200)
committerPeter Michael Green <plugwash@raspbian.org>
Mon, 15 Nov 2021 00:13:31 +0000 (00:13 +0000)
These should help diagnose problems when dealing with error failures.
In particular this helped distinguish the problem with io_pgetevents()
not being implemented and it failing due to the sigset_t layout bug.

Signed-off-by: Guillem Jover <guillem@hadrons.org>
[JEM: fix up 80 columns violations]
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Gbp-Pq: Topic upstream
Gbp-Pq: Name 0027-harness-Print-better-error-messages-on-error-conditi.patch

harness/cases/22.t

index b13024e06a99b11a1be1f6ac5110208ebf9d93b4..c47140de6459e1db1ea5128d4afc938064064f2f 100644 (file)
@@ -76,7 +76,7 @@ int test_main(void)
 
                ret = io_setup(1, &ctx);
                if (ret) {
-                       printf("child: io_setup failed\n");
+                       printf("child: io_setup failed: %s\n", strerror(-ret));
                        return 1;
                }
 
@@ -86,7 +86,7 @@ int test_main(void)
                        /* if poll isn't supported, skip the test */
                        if (ret == -EINVAL)
                                return 3;
-                       printf("child: io_submit failed\n");
+                       printf("child: io_submit failed: %s\n", strerror(-ret));
                        return 1;
                }
 
@@ -99,7 +99,8 @@ int test_main(void)
                } while (ret == 0);
 
                if (ret != -EINTR) {
-                       printf("child: io_pgetevents did not set errno to EINTR\n");
+                       printf("child: io_pgetevents did not set errno to "
+                              "EINTR: %s\n", strerror(-ret));
                        return 1;
                }
 
@@ -117,7 +118,7 @@ int test_main(void)
 
                ret = io_setup(1, &ctx);
                if (ret) {
-                       printf("parent: io_setup failed\n");
+                       printf("parent: io_setup failed: %s\n", strerror(-ret));
                        return 1;
                }
 
@@ -126,7 +127,8 @@ int test_main(void)
                        /* if poll isn't supported, skip the test */
                        if (ret == -EINVAL)
                                return 3;
-                       printf("parent: io_submit failed with %d\n", ret);
+                       printf("parent: io_submit failed with %d: %s\n",
+                              ret, strerror(-ret));
                        return 1;
                }
 
@@ -134,7 +136,8 @@ int test_main(void)
 
                ret = io_pgetevents(ctx, 1, 1, &ev, NULL, &sigmask);
                if (ret < 0) {
-                       printf("parent: io_pgetevents failed\n");
+                       printf("parent: io_pgetevents failed: %s\n",
+                              strerror(-ret));
                        return 1;
                }
                if (ret != 1) {