common/multicall: Increase debugability for bad hypercalls
authorAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 31 Oct 2017 17:07:41 +0000 (17:07 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 2 Nov 2017 16:49:57 +0000 (16:49 +0000)
commitff93dc55431517ed29c70dbff6721c6b0803acf9
treede2eb00d24d5f9138dfe6bd567f8c3ee9d7bc5c3
parenta79d4503e48739b48533737de6978397d8b3e69e
common/multicall: Increase debugability for bad hypercalls

While investigating an issue (in a new codepath I'd introduced, as it turns
out), leaving interrupts disabled manifested as a subsequent op in the
multicall failing a check_lock() test.

The codepath would have hit the ASSERT_NOT_IN_ATOMIC on the return-to-guest
path, had it not hit the check_lock() first.

Call ASSERT_NOT_IN_ATOMIC() after each operation in the multicall, to make
failures more obvious.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Release-acked-by: Julien Grall <julien.grall@linaro.org>
xen/common/multicall.c