curl: Make socket callback during cleanup into no-op
authorColin Walters <walters@verbum.org>
Wed, 18 Sep 2024 17:41:59 +0000 (13:41 -0400)
committerSimon McVittie <smcv@debian.org>
Thu, 19 Sep 2024 08:57:08 +0000 (09:57 +0100)
commitff444b1610b9b5080700055295fc809ef1d52278
tree038d02ec85652e3cf1d38e9e6ded86aab49d1045
parent178e7d311284813d88f64a6cdd4e7d29339db666
curl: Make socket callback during cleanup into no-op

Because curl_multi_cleanup may invoke callbacks, we effectively have
some circular references going on here. See discussion in

https://github.com/curl/curl/issues/14860

Basically what we do is the socket callback libcurl may invoke into a no-op when
we detect we're finalizing. The data structures are owned by this object and
not by the callbacks, and will be destroyed below. Note that
e.g. g_hash_table_unref() may itself invoke callbacks, which is where
some data is cleaned up.

Signed-off-by: Colin Walters <walters@verbum.org>
Origin: upstream, 2024.8, commit:4d755a85225ea0a02d4580d088bb8a97138cb040
Bug: https://github.com/ostreedev/ostree/issues/3299
Bug-Debian: https://bugs.debian.org/1082121

Gbp-Pq: Name curl-Make-socket-callback-during-cleanup-into-no-op.patch
src/libostree/ostree-fetcher-curl.c