QXmlStreamReader: Raise error on unexpected tokens
authorDebian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Thu, 27 Mar 2025 11:24:29 +0000 (14:24 +0300)
committerDmitry Shachnev <mitya57@debian.org>
Thu, 27 Mar 2025 11:24:29 +0000 (14:24 +0300)
commitfe81d77128646e866b1bbb458eb63e37dc6a8276
tree040e3b4b1ab54705fe0c12b078e5a8d15b28f130
parentacbf1eea18226d21acddbf3f0815891c76028d47
QXmlStreamReader: Raise error on unexpected tokens

Origin: upstream, https://download.qt.io/official_releases/qt/5.15/CVE-2023-38197-qtbase-5.15.diff
Last-Update: 2023-07-15

QXmlStreamReader accepted multiple DOCTYPE elements, containing DTD
fragments in the XML prolog, and in the XML body.
Well-formed but invalid XML files - with multiple DTD fragments in
prolog and body, combined with recursive entity expansions - have
caused infinite loops in QXmlStreamReader.

This patch implements a token check in QXmlStreamReader.
A stream is allowed to start with an XML prolog. StartDocument
and DOCTYPE elements are only allowed in this prolog, which
may also contain ProcessingInstruction and Comment elements.
As soon as anything else is seen, the prolog ends.
After that, the prolog-specific elements are treated as unexpected.
Furthermore, the prolog can contain at most one DOCTYPE element.

Update the documentation to reflect the new behavior.
Add an autotest that checks the new error cases are correctly detected,
and no error is raised for legitimate input.

The original OSS-Fuzz files (see bug reports) are not included in this
patch for file size reasons. They have been tested manually. Each of
them has more than one DOCTYPE element, causing infinite loops in
recursive entity expansions. The newly implemented functionality
detects those invalid DTD fragments. By raising an error, it aborts
stream reading before an infinite loop occurs.

Thanks to OSS-Fuzz for finding this.

Gbp-Pq: Name CVE-2023-38197.diff
src/corelib/serialization/qxmlstream.cpp
src/corelib/serialization/qxmlstream_p.h
tests/auto/corelib/serialization/qxmlstream/tokenError/dtdInBody.xml [new file with mode: 0644]
tests/auto/corelib/serialization/qxmlstream/tokenError/multipleDtd.xml [new file with mode: 0644]
tests/auto/corelib/serialization/qxmlstream/tokenError/wellFormed.xml [new file with mode: 0644]
tests/auto/corelib/serialization/qxmlstream/tst_qxmlstream.cpp