ask-password: prevent buffer overflow when reading from keyring
authorMichael Biebl <biebl@debian.org>
Thu, 27 Jun 2019 13:02:40 +0000 (15:02 +0200)
committerMichael Biebl <biebl@debian.org>
Wed, 16 Oct 2019 13:24:54 +0000 (14:24 +0100)
commitfd3390975fb3cbb14eb15ff951c9298e05631545
treeddf852bea47c98230e6e0d2f06a05dbd6d338b2d
parent557b2ab23fd4e40c590397c422d94bf5d26d90a5
ask-password: prevent buffer overflow when reading from keyring

When we read from keyring, a temporary buffer is allocated in order to
determine the size needed for the entire data. However, when zeroing that area,
we use the data size returned by the read instead of the lesser size allocate
for the buffer.

That will cause memory corruption that causes systemd-cryptsetup to crash
either when a single large password is used or when multiple passwords have
already been pushed to the keyring.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
(cherry picked from commit 59c55e73eaee345e1ee67c23eace8895ed499693)

Gbp-Pq: Name ask-password-prevent-buffer-overflow-when-reading-from-ke.patch
src/shared/ask-password-api.c