x86: Fix build with the get/set_reg() infrastructure
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 26 Jan 2022 11:17:04 +0000 (12:17 +0100)
committerJan Beulich <jbeulich@suse.com>
Wed, 26 Jan 2022 11:17:04 +0000 (12:17 +0100)
commitfc87b55a3429961eeece0e6f4a103a23700b1ff4
treeac10bf982af2af2f3c602114e67855eab7f98a77
parentd3cb5470292eeff776e0c95a7f1e1c9e427d6425
x86: Fix build with the get/set_reg() infrastructure

I clearly messed up concluding that the stubs were safe to drop.

The is_{pv,hvm}_domain() predicates are not symmetrical with both CONFIG_PV
and CONFIG_HVM.  As a result logic of the form `if ( pv/hvm ) ... else ...`
will always have one side which can't be DCE'd.

While technically only the hvm stubs are needed, due to the use of the
is_pv_domain() predicate in guest_{rd,wr}msr(), sort out the pv stubs too to
avoid leaving a bear trap for future users.

Fixes: 88d3ff7ab15d ("x86/guest: Introduce {get,set}_reg() infrastructure")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
master commit: 13caa585791234fe3e3719c8376f7ea731012451
master date: 2022-01-21 12:42:11 +0000
xen/include/asm-x86/hvm/hvm.h
xen/include/asm-x86/pv/domain.h