tests: Reset umask to 022 while creating test repository
authorSimon McVittie <smcv@collabora.com>
Tue, 19 Sep 2017 17:37:58 +0000 (18:37 +0100)
committerSimon McVittie <smcv@debian.org>
Fri, 22 Sep 2017 14:48:24 +0000 (15:48 +0100)
commitf7c168aceac899dc50944614d8cffd5787f6cfe6
tree0f86da2db1caa6f5a28c1196db369d95beee8808
parent00134510bdae100ae3c62777ccf610900bcbafa2
tests: Reset umask to 022 while creating test repository

In test-basic-root.sh we make assertions about the permissions
of files like baz/cow, which were created without an explicit chmod.
We can't do that unless we control the permissions.

For some reason the "debomatic" autobuilder used to do some Debian
archive rebuilds does the entire build including build-time tests
as uid 0 with umask 002, which broke those assertions. This seems
a weird thing to do, and I've opened a bug, but it also seems
reasonable to fix this test.

This also lets us remove a couple of existing workarounds for the
same issue.

Bug-Debian: https://bugs.debian.org/876138
Signed-off-by: Simon McVittie <smcv@collabora.com>
Closes: #1192
Approved by: cgwalters
Forwarded: https://github.com/ostreedev/ostree/pull/1192
Applied-upstream: 2017.12, commit:e3c3ec5dd91492e82c79223052443d038c60f41c

Gbp-Pq: Topic 2017.12
Gbp-Pq: Name tests-Reset-umask-to-022-while-creating-test-repository.patch
tests/libtest.sh
tests/test-basic-user.sh