xfs: validate bdev support for DAX inode flag
authorRoss Zwisler <ross.zwisler@linux.intel.com>
Mon, 18 Sep 2017 21:46:03 +0000 (14:46 -0700)
committerpopcornmix <popcornmix@gmail.com>
Fri, 6 Oct 2017 12:06:51 +0000 (13:06 +0100)
commitf4da23d6fb479cbc3af75eb2e5ba166fe57adf68
tree595f12a17197879d894e679b8f5b265dfdaa9060
parent5b255cdd2eaa32ddef98bf08d10b99b3800380aa
xfs: validate bdev support for DAX inode flag

commit 6851a3db7e224bbb85e23b3c64a506c9e0904382 upstream.

Currently only the blocksize is checked, but we should really be calling
bdev_dax_supported() which also tests to make sure we can get a
struct dax_device and that the dax_direct_access() path is working.

This is the same check that we do for the "-o dax" mount option in
xfs_fs_fill_super().

This does not fix the race issues that caused the XFS DAX inode option to
be disabled, so that option will still be disabled.  If/when we re-enable
it, though, I think we will want this issue to have been fixed.  I also do
think that we want to fix this in stable kernels.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/xfs/xfs_ioctl.c