tests: Reset umask to 022 while creating test repository
authorSimon McVittie <smcv@collabora.com>
Tue, 19 Sep 2017 17:37:58 +0000 (18:37 +0100)
committerPeter Michael Green <plugwash@raspbian.org>
Thu, 28 Sep 2017 16:17:06 +0000 (17:17 +0100)
commitf2ed045c581e38e52bb8290f052a4d3c3637d9d0
tree8f58d6cb13473ce7082be51cc4e504dadc749785
parent432661a596a73aaedad24caa280d4bdd8ba8a4dc
tests: Reset umask to 022 while creating test repository

In test-basic-root.sh we make assertions about the permissions
of files like baz/cow, which were created without an explicit chmod.
We can't do that unless we control the permissions.

For some reason the "debomatic" autobuilder used to do some Debian
archive rebuilds does the entire build including build-time tests
as uid 0 with umask 002, which broke those assertions. This seems
a weird thing to do, and I've opened a bug, but it also seems
reasonable to fix this test.

This also lets us remove a couple of existing workarounds for the
same issue.

Bug-Debian: https://bugs.debian.org/876138
Signed-off-by: Simon McVittie <smcv@collabora.com>
Closes: #1192
Approved by: cgwalters
Forwarded: https://github.com/ostreedev/ostree/pull/1192
Applied-upstream: 2017.12, commit:e3c3ec5dd91492e82c79223052443d038c60f41c

Gbp-Pq: Topic 2017.12
Gbp-Pq: Name tests-Reset-umask-to-022-while-creating-test-repository.patch
tests/libtest.sh
tests/test-basic-user.sh