xz: validate the value before assigning it to an enum variable
authorLasse Collin <lasse.collin@tukaani.org>
Thu, 10 Mar 2022 08:47:26 +0000 (09:47 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 10 Mar 2022 08:47:26 +0000 (09:47 +0100)
commitee4d66242eef4d4c4215a432dece577093bfcbbc
treeba3fb04fec797e5292cce52da471d797c5206584
parent6a6600cebbbe7cc734b388f48aa3475d75916e71
xz: validate the value before assigning it to an enum variable

This might matter, for example, if the underlying type of enum xz_check
was a signed char. In such a case the validation wouldn't have caught an
unsupported header. I don't know if this problem can occur in the kernel
on any arch but it's still good to fix it because some people might copy
the XZ code to their own projects from Linux instead of the upstream
XZ Embedded repository.

This change may increase the code size by a few bytes. An alternative
would have been to use an unsigned int instead of enum xz_check but
using an enumeration looks cleaner.

Link: https://lore.kernel.org/r/20211010213145.17462-3-xiang@kernel.org
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4f8d7abaa413
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
master commit: 0a21660515c24f09c4ee060ce0bb42e4b2e6b6fa
master date: 2022-03-07 09:08:54 +0100
xen/common/xz/dec_stream.c