libelf: improve errors in elf_xen_note_check()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 28 Oct 2013 11:30:35 +0000 (11:30 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Mon, 28 Oct 2013 14:49:31 +0000 (14:49 +0000)
commite6564c634863680f6541e07ce2f77f17d45ce52e
treee2ff2ab251d7b01f42bc5f9bb4e6a432ed1b353b
parent8f5a051507537aa01995dd0a97a50d1c96fcc2b4
libelf: improve errors in elf_xen_note_check()

I recently debugged an isolated failure to boot, with no information other
than the logs.

The "Will only load images built for the generic loader or Linux images"
string was missing a newline, leading to the subsequent error being appended
to this line, rather than having its own line with correctly identified
function.

Furthermore, error messages which state "param containing $FOO is not $BAR" is
fairly useless for debugging without identifying which bad $FOO caused the
failure.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
xen/common/libelf/libelf-dominfo.c