tools/lib/api/fs/fs.c: Fix misuse of strncpy()
authorBen Hutchings <ben@decadent.org.uk>
Thu, 19 Jul 2018 22:36:52 +0000 (23:36 +0100)
committerSalvatore Bonaccorso <carnil@debian.org>
Thu, 26 Sep 2019 12:19:06 +0000 (13:19 +0100)
commite2df19bc3afaa6c3d4842ee97672661b5aa3ad97
tree7a3f3b2221bbdadbfd262bafc7ad0f56ab83a3e9
parent87b0be4f2470e1ea399cfaab8d4d60843260d492
tools/lib/api/fs/fs.c: Fix misuse of strncpy()

gcc 8 reports:

In function 'fs__env_override',
    inlined from 'fs__get_mountpoint' at fs/fs.c:228:6:
fs/fs.c:222:2: error: 'strncpy' specified bound 4096 equals destination size [-Werror=stringop-truncation]
  strncpy(fs->path, override_path, sizeof(fs->path));
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I'm not convinced it makes sense to truncate the copied string here,
but since we're already doing so let's ensure it's still null-
terminated.  Use strlcpy() instead.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name tools-lib-api-fs-fs.c-fix-misuse-of-strncpy.patch
tools/lib/api/fs/fs.c