x86emul: address x86_insn_is_mem_{access,write}() omissions
authorJan Beulich <jbeulich@suse.com>
Fri, 29 May 2020 15:28:04 +0000 (17:28 +0200)
committerJan Beulich <jbeulich@suse.com>
Fri, 29 May 2020 15:28:04 +0000 (17:28 +0200)
commite28d13eeb65c25c0bd56e8bfa83c7473047d778d
tree3776ce3d1d15ec45a5351486e07b1512803af7f3
parent9b9a83e43598b231111487378d6037fa8fa473d5
x86emul: address x86_insn_is_mem_{access,write}() omissions

First of all explain in comments what the functions' purposes are. Then
make them actually match their comments.

Note that fc6fa977be54 ("x86emul: extend x86_insn_is_mem_write()
coverage") didn't actually fix the function's behavior for {,V}STMXCSR:
Both are covered by generic code higher up in the function, due to
x86_decode_twobyte() already doing suitable adjustments. And VSTMXCSR
wouldn't have been covered anyway without a further X86EMUL_OPC_VEX()
case label. Keep the inner case label in a comment for reference.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/x86_emulate/x86_emulate.c