avcodec/arm/sbcenc: avoid callee preserved vfp registers
authorJames Cowgill <jcowgill@debian.org>
Sun, 11 Aug 2019 15:50:56 +0000 (16:50 +0100)
committerSebastian Ramacher <sramacher@debian.org>
Sat, 15 Jan 2022 16:49:38 +0000 (16:49 +0000)
commite074232edf6f4c580425de8ce1387104634870ae
treef4adc742ec0bb082ede171afe0edaf16f01df0fd
parent79832d8c5689154da38d48edbea7b3d1f573b8c2
avcodec/arm/sbcenc: avoid callee preserved vfp registers

When compiling FFmpeg with GCC-9, some very random segfaults were
observed in code which had previously called down into the SBC encoder
NEON assembly routines. This was caused by these functions clobbering
some of the vfp callee saved registers (d8 - d15 aka q4 - q7). GCC was
using these registers to save local variables, but after these
functions returned, they would contain garbage.

Fix by reallocating the registers in the two affected functions in
the following way:
 ff_sbc_analyze_4_neon: q2-q5 => q8-q11, then q1-q4 => q8-q11
 ff_sbc_analyze_8_neon: q2-q9 => q8-q15

The reason for using these replacements is to keep closely related
sets of registers consecutively numbered which hopefully makes the
code more easy to follow. Since this commit only reallocates
registers, it should have no performance impact.

Signed-off-by: James Cowgill <jcowgill@debian.org>
Gbp-Pq: Name 0001-avcodec-arm-sbcenc-avoid-callee-preserved-vfp-regist.patch
libavcodec/arm/sbcdsp_neon.S