common/vsprintf: fix signed->unsigned error, causing glacial performance
authorAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 12 Nov 2013 16:20:34 +0000 (17:20 +0100)
committerJan Beulich <jbeulich@suse.com>
Tue, 12 Nov 2013 16:20:34 +0000 (17:20 +0100)
commitddd48f0ea099621ef1e891f634b938dda76a5bba
tree54fd2b4bc68fb435ef8e49979e91f8f08adf09e2
parentf15eacdd5a2170e8d870f4624278e1ea310c46c7
common/vsprintf: fix signed->unsigned error, causing glacial performance

The original patch for

  c/s 67a3542c5bc356e6452d8305991617c875f87de4
  "common/vsprintf: Refactor string() out of vsnprintf()"

specifically used signed integers, identical to the code copied out of vsprintf.

When committed, these had changed to unsigned integers, which causes a
functional change.  This causes glacial boot performance and an excessive
quantity of spaces printed to the serial console, as we loop to the upper
bound of a 32bit integer.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/common/vsprintf.c