[PATCH 2/6] common: Always let QVariant::fromValue() deduce the type
authorManuel Nickschas <sputnick@quassel-irc.org>
Tue, 7 Jan 2020 17:39:48 +0000 (18:39 +0100)
committerFelix Geyer <fgeyer@debian.org>
Mon, 13 Jul 2020 21:13:31 +0000 (22:13 +0100)
commitd9334484a992ebe6bd5a80a885e2e47a834af18a
treed417d26769d41402de7cc6d9906d969a7f9eb02f
parentdc22124321bc08c8fe15dd16440b85ee9ae950e6
[PATCH 2/6] common: Always let QVariant::fromValue() deduce the type

From 41bf70c263ee0af80ad1850fabe77ffffee188f4 Mon Sep 17 00:00:00 2001
Bug: https://bugs.quassel-irc.org/issues/1544
Bug-Ubuntu: https://bugs.launchpad.net/quassel/+bug/1885436
Origin: upstream, https://github.com/quassel/quassel/pull/518
Origin: upstream, https://github.com/quassel/quassel/commit/41bf70c263ee0af80ad1850fabe77ffffee188f4

In some places, we would explicitly give the type to
QVariant::fromValue(), forgoing automatic type deduction. This is
almost always redundant, and in the cases where it is not, the
input type should be explicitly cast.

Additionally, the implementation of QVariant::fromValue() subtly changed
in Qt 5.14, leading to compile errors when giving a non-decayed type
(as we did in SignalProxy::attachSignal()).

Gbp-Pq: Topic qt514
Gbp-Pq: Name 0002-common-Always-let-QVariant-fromValue-deduce-the-type.patch
19 files changed:
src/client/coreaccountmodel.cpp
src/client/messagefilter.cpp
src/client/messagemodel.cpp
src/client/networkmodel.cpp
src/common/buffersyncer.cpp
src/common/network.cpp
src/common/serializers/serializers.cpp
src/common/types.h
src/common/util.h
src/core/core.cpp
src/qtui/chatitem.cpp
src/qtui/chatlinemodelitem.cpp
src/qtui/mainwin.cpp
src/qtui/settingsdlg.cpp
src/qtui/settingspages/chatmonitorsettingspage.cpp
src/qtui/settingspages/networkssettingspage.cpp
src/qtui/settingspages/shortcutsmodel.cpp
src/uisupport/networkmodelcontroller.cpp
src/uisupport/toolbaractionprovider.cpp