[PATCH] os/bluestore/BlueFS: use uint64_t for `len`
authorKefu Chai <kchai@redhat.com>
Fri, 28 Jun 2019 03:35:54 +0000 (11:35 +0800)
committerThomas Goirand <zigo@debian.org>
Thu, 27 May 2021 10:04:21 +0000 (11:04 +0100)
commitcfc5f6335283137d4979036d086935cd501710b7
tree78637b38bb77f2de0f5d7412b2661c716d001da3
parent49d7dad7233c351bf871e96196c1e053fad680f3
[PATCH] os/bluestore/BlueFS: use uint64_t for `len`

change the type of parameter `len` of `BlueFS::_read_random()` from
`size_t` to `uint64_t`.

i think the type of `size_t` comes from
`rocksdb::RandomAccessFile::Read(uint64_t offset, size_t n,
rocksdb::Slice* result, char* scratch)`. and when we implement this
method, we continued using `n`'s type. but, we are using it with
`std::min()`, for instance, where the template parameter type deduction
fails if the lhs and rhs parameters' types are different. so probaly the
better solution is to use `uint64_t` directly to avoid the the cast and
specializing the template.

Signed-off-by: Kefu Chai <kchai@redhat.com>
Gbp-Pq: Name bluefs-use-uint64_t-for-len.patch
src/os/bluestore/BlueFS.cc
src/os/bluestore/BlueFS.h