arm64: compat: Implement misalignment fixups for multiword loads
authorArd Biesheuvel <ardb@kernel.org>
Fri, 1 Jul 2022 13:53:22 +0000 (15:53 +0200)
committerSalvatore Bonaccorso <carnil@debian.org>
Fri, 21 Oct 2022 20:24:21 +0000 (21:24 +0100)
commitcf7245844af2ad69c52df48b0608c43d96f7c285
tree7ca4466c3a1b03283060427d3bb95101a6623a01
parentff28c082e773bf34d527f105e7c7f5c5c2c23fe7
arm64: compat: Implement misalignment fixups for multiword loads

Origin: https://git.kernel.org/linus/3fc24ef32d3b9368f4c103dcd21d6a3f959b4870

The 32-bit ARM kernel implements fixups on behalf of user space when
using LDM/STM or LDRD/STRD instructions on addresses that are not 32-bit
aligned. This is not something that is supported by the architecture,
but was done anyway to increase compatibility with user space software,
which mostly targeted x86 at the time and did not care about aligned
accesses.

This feature is one of the remaining impediments to being able to switch
to 64-bit kernels on 64-bit capable hardware running 32-bit user space,
so let's implement it for the arm64 compat layer as well.

Note that the intent is to implement the exact same handling of
misaligned multi-word loads and stores as the 32-bit kernel does,
including what appears to be missing support for user space programs
that rely on SETEND to switch to a different byte order and back. Also,
like the 32-bit ARM version, we rely on the faulting address reported by
the CPU to infer the memory address, instead of decoding the instruction
fully to obtain this information.

This implementation is taken from the 32-bit ARM tree, with all pieces
removed that deal with instructions other than LDRD/STRD and LDM/STM, or
that deal with alignment exceptions taken in kernel mode.

Cc: debian-arm@lists.debian.org
Cc: Vagrant Cascadian <vagrant@debian.org>
Cc: Riku Voipio <riku.voipio@iki.fi>
Cc: Steve McIntyre <steve@einval.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20220701135322.3025321-1-ardb@kernel.org
[catalin.marinas@arm.com: change the option to 'default n']
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Gbp-Pq: Topic features/arm64
Gbp-Pq: Name arm64-compat-Implement-misalignment-fixups-for-multi.patch
arch/arm64/Kconfig
arch/arm64/include/asm/exception.h
arch/arm64/kernel/Makefile
arch/arm64/kernel/compat_alignment.c [new file with mode: 0644]
arch/arm64/mm/fault.c