SSL error handling: Remove unnecessary confusing code
authorChristian Kamm <mail@ckamm.de>
Thu, 27 Apr 2017 08:13:55 +0000 (10:13 +0200)
committerckamm <mail@ckamm.de>
Thu, 4 May 2017 07:19:01 +0000 (09:19 +0200)
commitc922015521451062c0c1e2ea41a9b30da4cf6a0b
tree8fa343854851acb80d11bfe7d7b083270badfa81
parent4ed9edb104ddf3b5196bf7f9ae8fd4827327d48a
SSL error handling: Remove unnecessary confusing code

I'm confident this is unnecessary. The original bug in #3283 was
to call ignoreSslErrors() without an argument in the 'accept'
case, which meant ignoring *all* subsequent SSL errors.

With that fixed, explicitly aborting the reply and resetting QNAM
is not needed since not ignoring the error will lead to the SSL
handshake failing.

See also:
  75b38d1a2ffe57d0f1eb3ebb8c5f30b8b2a185e4 (workaround introduced)
  89376e14d6135a6f39a6df99d54fde253573575c (real fix)
  76ce5adbf02af052ab8d7596b8ded75c7d4d7fcb (cherry-pick of workaround)
src/libsync/account.cpp