nspawn: consistently fail if parsing the environment fails
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Fri, 27 Sep 2019 11:58:06 +0000 (13:58 +0200)
committerMichael Biebl <biebl@debian.org>
Tue, 19 Nov 2019 08:17:12 +0000 (08:17 +0000)
commitc3d863075e942a1df6c8a5515d17af58d1f3e0b0
treed37fe2170aceda6407211e26ca649a25c062ca1e
parent55d2d460a6758937ff1fcb2f62960c1b934f6197
nspawn: consistently fail if parsing the environment fails

We would parse the environment twice (to re-apply settings after reading
config from disk), but we would not check the return code first time.
This means that for some settings we would ignore invalid values, while
for others, we'd fail at some point.

Let's just consistently fail. Those environment variables define important
aspects of behaviour, and it is better for the user if we ignore invalid
values. (Unknown settings are still ignored, so forward compatibility is
maintained.)

(cherry picked from commit 490486842b6521104b594c511ca912504f61a8f3)
(cherry picked from commit 9d8e889810b50b5be6eeecec637e4a8bdda30977)

Gbp-Pq: Name nspawn-consistently-fail-if-parsing-the-environment-fails.patch
src/nspawn/nspawn.c