test-webserver: Fix race condition
authorSimon McVittie <smcv@debian.org>
Tue, 28 Aug 2018 15:26:38 +0000 (16:26 +0100)
committerPeter Michael Green <plugwash@raspbian.org>
Sun, 16 Sep 2018 01:04:13 +0000 (02:04 +0100)
commitbd8523cbc7fd23bc271b480a377112b820566fd7
tree24bf72686466fe2f2dcfe0c5eeb33e9583943495
parent095bdd434796f550c4597878471369cceab9a3dc
test-webserver: Fix race condition

If we rely on the background subshell to create the httpd-output file,
and we are unlucky, then the "cp" invocation in the loop might execute
before the file has been created, and fail. This appears to have
happened on Debian's arm64 autobuilder, which failed with:

    Running web server: PYTHONUNBUFFERED=1 setsid python3 /<<PKGBUILDDIR>>/tests/http-utils-test-server.py 0
    Web server pid: 13319
    Waiting for web server (1/300)...
    cp: cannot stat '/var/tmp/tap-test.p1cxRN/httpd-output': No such file or directory

Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Name test-webserver-Fix-race-condition.patch
tests/test-webserver.sh