QQuickItem: avoid emitting signals during destruction
authorDebian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Sat, 8 Jul 2023 06:59:44 +0000 (07:59 +0100)
committerDmitry Shachnev <mitya57@debian.org>
Sat, 8 Jul 2023 06:59:44 +0000 (07:59 +0100)
commitbd556d80df28c63a6a80014267a6d5dd2329f01e
tree37831faa6c23faf115b0df15384d6c0e70660a44
parent9924e03ff430f19a8bc3dd00571b31505661b063
QQuickItem: avoid emitting signals during destruction

Origin: upstream, https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=74873324bdf33997
Last-Update: 2023-02-26

If a QQuickItem is in the QQuickItem destructor, then it is both unsafe
and unnecessary to emit property change notifications. Connected code
can no longer rely on the state of the emitting object - if it was
originally a subclass of QQuickItem, then those subclass destructors
will already have run. And the QQuickItem destructor will also have
partially run, leaving the object in an undefined state.

Add a flag that we set to true at the top of ~QQuickItem, and don't emit
visibleChildrenChanged, parentChanged, visibleChanged, and
childrenChanged for items that are partially destroyed already.

[ChangeLog][Qt Quick][QQuickItem] QQuickItem no longer emits change
notifications for the parent, children, visible, and visibleChildren
properties while it is being destroyed.

Gbp-Pq: Name qquickitem_no_signals_on_destruction.patch
src/quick/items/qquickitem.cpp
src/quick/items/qquickitem_p.h
tests/auto/quick/qquickitem2/tst_qquickitem.cpp