fetcher: Always open tmpfiles in repo (except on FUSE)
authorColin Walters <walters@verbum.org>
Thu, 29 Jun 2023 06:42:04 +0000 (02:42 -0400)
committerColin Walters <walters@verbum.org>
Wed, 5 Jul 2023 08:27:36 +0000 (04:27 -0400)
commitba9c9dedffb953738c609fda6502b9b37ee1b6ba
tree07da633827bec6d5c0508ec730ab78cecdc600c5
parent8999d41127572d27ab12474f1754d1ae0c19f187
fetcher: Always open tmpfiles in repo (except on FUSE)

This reverts commit 4e61e6f7d0d6aebd6abcdc455ec53164afe39e8d
and re-instates the fix for ensuring that we download temporary
files into the repository location.

However in order to ensure we don't re-introduce
https://github.com/ostreedev/ostree/issues/2900
we detect the case where we're writing to a FUSE mount
and keep the prior behavior.

I've verified that this works with flatpak.

Note a downside of this is the change needs to be triplicated
across the 3 http backends.

This then again
Closes: https://github.com/ostreedev/ostree/issues/2571
src/libostree/ostree-fetcher-curl.c
src/libostree/ostree-fetcher-soup.c
src/libostree/ostree-fetcher-soup3.c
src/libostree/ostree-fetcher-util.h
src/libostree/ostree-fetcher.h
src/libostree/ostree-repo-private.h
src/libostree/ostree-repo-pull.c
src/libostree/ostree-repo.c