x86/vioapic: check IRR before attempting to inject interrupt after EOI
authorRoger Pau Monné <roger.pau@citrix.com>
Fri, 22 Jan 2021 11:13:05 +0000 (12:13 +0100)
committerJan Beulich <jbeulich@suse.com>
Fri, 22 Jan 2021 11:13:05 +0000 (12:13 +0100)
commitba584fb1a26c058ebd0e6a2779287b3e4400415c
treef012309ba3134124847766012054f2478748e85f
parent24114840ea4f82b6958ba0d7ac5e4cec44aafe11
x86/vioapic: check IRR before attempting to inject interrupt after EOI

In vioapic_update_EOI the irq_lock will be dropped in order to forward
the EOI to the dpci handler, so there's a window between clearing IRR
and checking if the line is asserted where IRR can change behind our
back.

Fix this by checking whether IRR is set before attempting to inject a
new interrupt.

Fixes: 06e3f8f2766 ('vt-d: Do dpci eoi outside of irq_lock.')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/hvm/vioapic.c