ext4: fail ext4_iget for root directory if unallocated
authorTheodore Ts'o <tytso@mit.edu>
Fri, 30 Mar 2018 01:56:09 +0000 (21:56 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 19 Apr 2018 10:13:03 +0000 (11:13 +0100)
commitba2628ac58376b10e5ee03399089dc28adcb5c5b
tree01635ab8e605c78f625676d3aacbca7eb8c2cbc6
parentb28d06bb0573edb6d43b74170ad2282ea6f10329
ext4: fail ext4_iget for root directory if unallocated

If the root directory has an i_links_count of zero, then when the file
system is mounted, then when ext4_fill_super() notices the problem and
tries to call iput() the root directory in the error return path,
ext4_evict_inode() will try to free the inode on disk, before all of
the file system structures are set up, and this will result in an OOPS
caused by a NULL pointer dereference.

This issue has been assigned CVE-2018-1092.

https://bugzilla.kernel.org/show_bug.cgi?id=199179
https://bugzilla.redhat.com/show_bug.cgi?id=1560777

Reported-by: Wen Xu <wen.xu@gatech.edu>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name ext4-fail-ext4_iget-for-root-directory-if-unallocate.patch
fs/ext4/inode.c