libxc: Fix misleading use of strncpy code in build_hvm_info()
authorJennifer Herbert <Jennifer.Herbert@citrix.com>
Wed, 1 Jul 2015 17:37:11 +0000 (17:37 +0000)
committerIan Campbell <ian.campbell@citrix.com>
Fri, 3 Jul 2015 15:48:18 +0000 (16:48 +0100)
commitb9dbe33d15a038500bcc3226a3ca31ee215122cd
treec7251d5b92fb3f126ef7e32434387c364663fee1
parent7d403f5bc7b5f045103f67bededd136ac3461e35
libxc: Fix misleading use of strncpy code in build_hvm_info()

hvm_info->signature is not a string, but an 64 bit int, and is not
NULL terminated.  The use of strncpy to populate it is inappropriate and
potentially misleading.  A cursory glance might have you thinking someone
had miscounted the length of the string literal - not realising it was
intentionally cropping of the null termination.
Also, since we wish to initialise all of hvm_info->signature, and
certainly no more, the use of sizeof is safer.

Coverity-ID: 1198710

Signed-off-by: Jennifer Herbert <jennifer.herbert@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxc/xc_hvm_build_x86.c