scsi: qla2xxx: Fix an integer overflow in sysfs code
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 30 Aug 2017 13:30:35 +0000 (16:30 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 19 Sep 2017 01:34:05 +0000 (02:34 +0100)
commitb2c4f51e55f9eddfb7b6cd9fc5282784603be92b
treea50496400a166d4187bdcb50c1b7a359ae761290
parentf6c31352d4e6722b1ad6e853bc01229a5e4e8b53
scsi: qla2xxx: Fix an integer overflow in sysfs code

The value of "size" comes from the user.  When we add "start + size" it
could lead to an integer overflow bug.

It means we vmalloc() a lot more memory than we had intended.  I believe
that on 64 bit systems vmalloc() can succeed even if we ask it to
allocate huge 4GB buffers.  So we would get memory corruption and likely
a crash when we call ha->isp_ops->write_optrom() and ->read_optrom().

Only root can trigger this bug.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=194061
Cc: <stable@vger.kernel.org>
Fixes: b7cc176c9eb3 ("[SCSI] qla2xxx: Allow region-based flash-part accesses.")
Reported-by: shqking <shqking@gmail.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name scsi-qla2xxx-fix-an-integer-overflow-in-sysfs-code.patch
drivers/scsi/qla2xxx/qla_attr.c