libcxx-test-fix-lockfree-test-for-i386
authorLLVM Packaging Team <pkg-llvm-team@lists.alioth.debian.org>
Thu, 23 Jan 2020 13:30:57 +0000 (13:30 +0000)
committerGianfranco Costamagna <locutusofborg@debian.org>
Thu, 23 Jan 2020 13:30:57 +0000 (13:30 +0000)
commitb14126b2b21b176189b2f55bb4c9834903bf2969
treebfff12eec223b8e716b3f5ea13dbd890a9ebc9ae
parent1a4d7f03fb539ad5d46e80abaff63ac52a7b67c5
libcxx-test-fix-lockfree-test-for-i386

Lock is_always_lock free test fails on i386 because std::atomic is aligned

Lock is_always_lock free test fails on i386 because std::atomic is aligned
to 8 bytes while long long is aligned to 4 bytes. clang can't generate inline
code for unaligned 8 byte atomics even tough instruction set and gcc support
it.

That makes it expected thaqt ATOMIC_LLONG_LOCK_FREE and
std::atomic<long long>::is_always_lock_free don't match on i386. Correct test
for std::atomic<long long> is to check if target cpu support cmpxchg8 instruction.
To set instruction support one can check __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8 define.

Bug: https://llvm.org/bugs/show_bug.cgi?id=19355

Gbp-Pq: Topic libcxx
Gbp-Pq: Name libcxx-test-fix-lockfree-test-for-i386.patch
libcxx/test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp