drm/vc4: simplify exit path of a failed allocation of dsi_connector
authorColin Ian King <colin.king@canonical.com>
Fri, 3 Feb 2017 19:56:24 +0000 (19:56 +0000)
committerRaspbian kernel package updater <root@raspbian.org>
Thu, 15 Feb 2018 17:41:15 +0000 (17:41 +0000)
commita52c919b20658cf132d6b6424c6fbba10aa17fc3
tree2f28ea47bb09f8b18e036e509eb4b1733a553c55
parent3edeafda9bc97e6fb8a563896e5b616b0b563c9b
drm/vc4: simplify exit path of a failed allocation of dsi_connector

If dsi_connector fails to allocate, the exit path via label 'fail'
checks if connector is null, which it always is, so the cleanup
that destroys connector is never going to be called.  Hence the
failure path can be more optimally performed by removing this
and just returning ERR_PTR(-ENOMEM).  This also removes the need
to initialize connector to NULL, and we can also remove ret too.

Detected by CoverityScan, CID#1399504 ("Logicall Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170203195624.7189-1-colin.king@canonical.com
(cherry picked from commit fce6a7bc22114c69b071bcf6fbfea2d07de6273c)
drivers/gpu/drm/vc4/vc4_dsi.c