x86/HVM: properly propagate errors from HVMOP_inject_msi
authorJan Beulich <jbeulich@suse.com>
Thu, 5 Jun 2014 15:45:27 +0000 (17:45 +0200)
committerJan Beulich <jbeulich@suse.com>
Thu, 5 Jun 2014 15:45:27 +0000 (17:45 +0200)
commita34dfb4ec1ac5c398b1160ad4a5ee290b717dd6d
tree7f84c38ab9b31df51b430caa12d2b26aff41977c
parenta310f00882dfd4b07baedbab1e102cd4d0a4e867
x86/HVM: properly propagate errors from HVMOP_inject_msi

There are a number of ways this operation can go wrong, all of which
got ignored so far.

In the context of this I wonder whether map_domain_emuirq_pirq()
returning 0 in the "already mapped" case is really intended to be that
way (this is why the subsequent NULL check here can't be an ASSERT()).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/hvm/hvm.c
xen/arch/x86/hvm/irq.c
xen/include/xen/hvm/irq.h