tools/tests/x86_emulator: Pass -no-pie -fno-pic to gcc on x86_32
authorIan Jackson <ian.jackson@citrix.com>
Tue, 1 Nov 2016 16:20:27 +0000 (16:20 +0000)
committerIan Jackson <ian.jackson@citrix.com>
Mon, 18 Jun 2018 15:10:38 +0000 (16:10 +0100)
commita246a7daa0d0c25158ccebad995a6c488c95eabf
treedbb17f17cc11ec25aea8c38d6afd6f3d9e62f241
parent9cc757a20ad3c0706980a0db8be266dfb2686973
tools/tests/x86_emulator: Pass -no-pie -fno-pic to gcc on x86_32

The current build fails with GCC6 on Debian sid i386 (unstable):

 /tmp/ccqjaueF.s: Assembler messages:
 /tmp/ccqjaueF.s:3713: Error: missing or invalid displacement expression `vmovd_to_reg_len@GOT'

This is due to the combination of GCC6, and Debian's decision to
enable some hardening flags by default (to try to make runtime
addresses less predictable):
  https://wiki.debian.org/Hardening/PIEByDefaultTransition

This is of no benefit for the x86 instruction emulator test, which is
a rebuild of the emulator code for testing purposes only.  So pass
options to disable this.

These options will be no-ops if they are the same as the compiler
default.

On amd64, the -fno-pic breaks the build in a different way.  So do
this only on i386.

Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
squash! tools/tests/x86_emulator: Pass -no-pie -fno-pic to gcc

Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
Gbp-Pq: Name 0028-tools-tests-x86_emulator-Pass-no-pie-fno-pic-to-gcc-.patch
tools/tests/x86_emulator/Makefile