test-webserver: Fix race condition
authorSimon McVittie <smcv@debian.org>
Tue, 28 Aug 2018 15:26:38 +0000 (16:26 +0100)
committerSimon McVittie <smcv@debian.org>
Tue, 28 Aug 2018 15:28:09 +0000 (16:28 +0100)
commita1cff25456a166444a354a7827a320fc86424e9a
treea442c565416009118cb7b3f2a54e0751014af0fe
parent018bb129bdd0bb549da5b1e54eb0bd86627aad1f
test-webserver: Fix race condition

If we rely on the background subshell to create the httpd-output file,
and we are unlucky, then the "cp" invocation in the loop might execute
before the file has been created, and fail. This appears to have
happened on Debian's arm64 autobuilder, which failed with:

    Running web server: PYTHONUNBUFFERED=1 setsid python3 /<<PKGBUILDDIR>>/tests/http-utils-test-server.py 0
    Web server pid: 13319
    Waiting for web server (1/300)...
    cp: cannot stat '/var/tmp/tap-test.p1cxRN/httpd-output': No such file or directory

Signed-off-by: Simon McVittie <smcv@debian.org>
Gbp-Pq: Name test-webserver-Fix-race-condition.patch
tests/test-webserver.sh