set geometry property in QXcbWindow after checking minimum size
authorDebian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Thu, 25 May 2023 10:45:05 +0000 (11:45 +0100)
committerDmitry Shachnev <mitya57@debian.org>
Thu, 25 May 2023 10:45:05 +0000 (11:45 +0100)
commita19d09e4896bacb73f84448f223611ea99a51e34
tree34d2c55e1f15a25aa11ba01e804aaf104b43c9f2
parent69380ffb8211a1c11a60a1b0b280c3734aac5ad2
set geometry property in QXcbWindow after checking minimum size

Origin: upstream, https://code.qt.io/cgit/qt/qtbase.git/commit/?id=6a3627b6c5aa5109
Last-Update: 2023-01-04

QXcbWindow::create() bound the window's size to windowMinimumSize(),
after its size had been inherited from parent().
QPlatformWindow::setGeometry() was called before that sanity check.

When a fullscreen window is re-mapped from a deactivated screen to the
remaining screen, the call to QPlatformWindow::setGeometry() assigns
an invalid QRect to QPlatformWindowPrivate::rect
The negative int values x2 and/or y2 cause
QXcbBackingStoreImage::flushPixmap to address unmapped memory and
crash.

This patch moves the call to QPlatformWindow::setGeometry() from
before to after bounding to a minimum value. That assures a valid
rectangle to be assigned in all cases.

Gbp-Pq: Name qxcbwindow_set_geometry.diff
src/plugins/platforms/xcb/qxcbwindow.cpp