serial: sh-sci: Fix panic when serial console and DMA are enabled
authorTakatoshi Akiyama <takatoshi.akiyama.kj@ps.hitachi-solutions.com>
Mon, 27 Feb 2017 06:56:31 +0000 (15:56 +0900)
committerRaspbian kernel package updater <root@raspbian.org>
Sun, 23 Jul 2017 02:56:46 +0000 (02:56 +0000)
commita06ca20b6778ec860537c9ffb8ad3d3768edfb63
treef8a6932a9a1c9ca7b5fba5a4c06ffa1680c98239
parent308b705ee628d9d96382088164d163ce1a714980
serial: sh-sci: Fix panic when serial console and DMA are enabled

commit 3c9101766b502a0163d1d437fada5801cf616be2 upstream.

This patch fixes an issue that kernel panic happens when DMA is enabled
and we press enter key while the kernel booting on the serial console.

* An interrupt may occur after sci_request_irq().
* DMA transfer area is initialized by setup_timer() in sci_request_dma()
  and used in interrupt.

If an interrupt occurred between sci_request_irq() and setup_timer() in
sci_request_dma(), DMA transfer area has not been initialized yet.
So, this patch changes the order of sci_request_irq() and
sci_request_dma().

Fixes: 73a19e4c0301 ("serial: sh-sci: Add DMA support.")
Signed-off-by: Takatoshi Akiyama <takatoshi.akiyama.kj@ps.hitachi-solutions.com>
[Shimoda changes the commit log]
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c