xen/banner: Drop the fig-to-oct.py script
authorAndrew Cooper <andrew.cooper3@citrix.com>
Sat, 7 Dec 2019 17:45:10 +0000 (17:45 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 10 Dec 2019 17:23:39 +0000 (17:23 +0000)
commit9fc7c88e6214a5a6f9baf1c4e89d3fa18af3110f
treeca2c8bbf91f9aecef8b0136f33bc8e7e16337524
parent8d5671eb31e4bf119bc067d4d8ca1c00cd779f84
xen/banner: Drop the fig-to-oct.py script

The script is 664 rather than 775, so the banner conversion doesn't actually
work if $(PYTHON) is empty:

  /bin/sh: tools/fig-to-oct.py: Permission denied
  make[3]: *** [include/xen/compile.h] Error 126
  make[3]: Leaving directory `/builds/xen-project/people/andyhhp/xen/xen'

Fixing this is easy, but using python here is wasteful.  compile.h doesn't
need XEN_BANNER rendering in octal, and text is much more simple to handle.
Replace fig-to-oct.py with a smaller sed script.  This could be a shell
one-liner, but it is much more simple to comment sensibly, and doesn't need to
include the added cognative load of makefile and shell escaping.

While changing this logic, take the opportunity to optimise the banner
space (and time on the serial port) by dropping trailing whitespace, which is
84 characters for current staging.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
xen/Makefile
xen/tools/fig-to-oct.py [deleted file]
xen/tools/process-banner.sed [new file with mode: 0755]