tools/libxl: Work around libvirt breakage in libxl__cpuid_legacy()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 2 Oct 2020 17:23:42 +0000 (18:23 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 2 Oct 2020 17:57:50 +0000 (18:57 +0100)
commit8ef6345ef557cc2c47298217635a3088eaa59893
treeafb559d6b25fe1ec0f8a48f26edbd43978ec953a
parent9ae1197582798b394d696cff94c4d742319bdbbf
tools/libxl: Work around libvirt breakage in libxl__cpuid_legacy()

OSSTest reports that libvirt is reliably regressed.

The only possible option is a side effect of using libxl_defbool_val(), which
can only be the assert() within.  Unfortunately, libvirt actually crashes in
__vfscanf_internal() while presumably trying to render some form of error.

Open code the check without the assert() to unblock staging, while we
investigate what is going on with libvirt.  This will want reverting at some
point in the future.

Not-really-fixes: bfcc97c08c ("tools/cpuid: Plumb nested_virt down into xc_cpuid_apply_policy()" reliably breaks libvirt.)
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
tools/libs/light/libxl_cpuid.c