staging: comedi: fix clean-up of comedi_class in comedi_init()
authorIan Abbott <abbotti@mev.co.uk>
Fri, 16 Jun 2017 18:35:34 +0000 (19:35 +0100)
committerRaspbian kernel package updater <root@raspbian.org>
Sun, 23 Jul 2017 03:09:23 +0000 (03:09 +0000)
commit86f34188c143cc77e98bc62418e70dc9efd7e57f
tree95ea7ffa1679bfe77814acaf778db2ff9a55be62
parent2ae09845471314bcd7079933b62646f20b9a2101
staging: comedi: fix clean-up of comedi_class in comedi_init()

commit a9332e9ad09c2644c99058fcf6ae2f355e93ce74 upstream.

There is a clean-up bug in the core comedi module initialization
functions, `comedi_init()`.  If the `comedi_num_legacy_minors` module
parameter is non-zero (and valid), it creates that many "legacy" devices
and registers them in SysFS.  A failure causes the function to clean up
and return an error.  Unfortunately, it fails to destroy the "comedi"
class that was created earlier.  Fix it by adding a call to
`class_destroy(comedi_class)` at the appropriate place in the clean-up
sequence.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/comedi_fops.c