sched: fix scheduler_disable() with core scheduling
authorSergey Dyasli <sergey.dyasli@citrix.com>
Fri, 17 Apr 2020 07:28:16 +0000 (09:28 +0200)
committerJan Beulich <jbeulich@suse.com>
Fri, 17 Apr 2020 07:28:16 +0000 (09:28 +0200)
commit82dd1a956d9b68f52e830d1dddfdfb4ab4d5a638
tree26d14874e51ad673a1adfe9edea377403a7459b0
parentee97008433f15e60478058c8ace514b939b6f862
sched: fix scheduler_disable() with core scheduling

In core-scheduling mode, Xen might crash when entering ACPI S5 state.
This happens in sched_slave() during is_idle_unit(next) check because
next->vcpu_list is stale and points to an already freed memory.

This situation happens shortly after scheduler_disable() is called if
some CPU is still inside sched_slave() softirq. Current logic simply
returns prev->next_task from sched_wait_rendezvous_in() which causes
the described crash because next_task->vcpu_list has become invalid.

Fix the crash by returning NULL from sched_wait_rendezvous_in() in
the case when scheduler_disable() has been called.

Signed-off-by: Sergey Dyasli <sergey.dyasli@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
xen/common/sched/core.c