watchdog/crash: Always disable watchdog in console_force_unlock()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 13 Aug 2013 12:31:01 +0000 (14:31 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 13 Aug 2013 12:31:01 +0000 (14:31 +0200)
commit7b9fa702ca323164d6b49e8b639a57f880454a8c
tree9ab2f8bfb2c8feb95cfebc060edfcbf1b26eefd3
parent896934596614b44c20a37263c9decb0b639ef995
watchdog/crash: Always disable watchdog in console_force_unlock()

Depending on the state of the conring and serial_tx_buffer,
console_force_unlock() can be a long running operation, usually because of
serial_start_sync()

XenServer testing has found a reliable case where console_force_unlock() on
one PCPU takes long enough for another PCPU to timeout due to the watchdog
(such as waiting for a tlb flush callin).

The watchdog timeout causes the second PCPU to repeat the
console_force_unlock(), at which point the first PCPU typically fails an
assertion in spin_unlock_irqrestore(&port->tx_lock) (because the tx_lock has
been unlocked behind itself).

console_force_unlock() is only on emergency paths, so one way or another the
host is going down.  Disable the watchdog before forcing the console lock to
help prevent having pcpus completing with each other to bring the host down.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
xen/arch/x86/x86_64/traps.c
xen/drivers/char/console.c