ask-password: prevent buffer overflow when reading from keyring
authorThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Mon, 13 May 2019 19:58:01 +0000 (16:58 -0300)
committerMichael Biebl <biebl@debian.org>
Wed, 4 Sep 2019 17:34:17 +0000 (18:34 +0100)
commit7a1a896a7527c952326096665d5cee1898ece797
treef6fb0387817656436d5fbd62f1ade9766c28a6ee
parent715a4593831003519cbce34c27eb48ea1431562c
ask-password: prevent buffer overflow when reading from keyring

When we read from keyring, a temporary buffer is allocated in order to
determine the size needed for the entire data. However, when zeroing that area,
we use the data size returned by the read instead of the lesser size allocate
for the buffer.

That will cause memory corruption that causes systemd-cryptsetup to crash
either when a single large password is used or when multiple passwords have
already been pushed to the keyring.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
(cherry picked from commit 59c55e73eaee345e1ee67c23eace8895ed499693)

Gbp-Pq: Name ask-password-prevent-buffer-overflow-when-reading-from-ke.patch
src/shared/ask-password-api.c