xl: support empty CDROM devices
authorIan Campbell <ian.campbell@citrix.com>
Thu, 26 Jul 2012 09:35:35 +0000 (10:35 +0100)
committerIan Campbell <ian.campbell@citrix.com>
Thu, 26 Jul 2012 09:35:35 +0000 (10:35 +0100)
commit79702808336453e6ec75777ea94f01027d439ebd
treeb6d7941b4a0cfaaf9cf546055d415eed96c9471c
parent214825a938dc04280f42efec9c2341e547c47890
xl: support empty CDROM devices

The important change here is to xlu_disk_parse to correctly set format == EMPTY
for CDROM devices which are empty. Test cases are added which check for
correctness here.

xend accepts ',hdc:cdrom,r'[0] as an empty CDROM drive however this is not
consistent with the xl syntax in docs/misc/xl-disk-configuration.txt which
requires ',,hdc:cdrom,r' (the additional positional paramter is the format).
I'm not sure if/how this can be fixed. Note that xend does not accept
',,hdc:cdrom,r'

There are several incidental cleanups included the the cdrom-{insert,eject}
commands:
  - add a dry-run mode
  - use the non-deprecated disk specification syntax
  - check for and report errors from libxl_cdrom_insert

[0] http://wiki.xen.org/wiki/CD_Rom_Support_in_Xen

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Campbell <ian.campbell@citrix.com>
docs/man/xl.pod.1
tools/libxl/check-xl-disk-parse
tools/libxl/libxlu_disk.c
tools/libxl/libxlu_disk_l.c
tools/libxl/libxlu_disk_l.h
tools/libxl/libxlu_disk_l.l
tools/libxl/xl_cmdimpl.c
tools/libxl/xl_cmdtable.c