domain: try to address Coverity pointing out a missing "break" in domain_teardown()
authorJan Beulich <jbeulich@suse.com>
Wed, 8 Sep 2021 12:38:33 +0000 (14:38 +0200)
committerJan Beulich <jbeulich@suse.com>
Wed, 8 Sep 2021 12:38:33 +0000 (14:38 +0200)
commit7429e08d9c1cabec3ce1c7c246fb711f6e225275
tree14e83b473f280bc309c546105f03cfd1a18aeb60
parenteb6bbf7b30da5bae87932514d54d0e3c68b23757
domain: try to address Coverity pointing out a missing "break" in domain_teardown()

Commit 806448806264 ("xen/domain: Fix label position in
domain_teardown()" has caused Coverity to report a _new_ supposedly
un-annotated fall-through in a switch(). I find this (once again)
puzzling; I'm having an increasingly hard time figuring what patterns
the tool is actually after. I would have expected that the tool would
either have spotted an issue also before this change, or not at all. Yet
if it had spotted one before, the statistics report should have included
an eliminated instance alongside the new one (because then the issue
would simply have moved by a few lines).

Hence the only thing I could guess is that the treatment of comments in
macro expansions might be subtly different. Therefore try whether
switching the comments to the still relatively new "fallthrough" pseudo
keyword actually helps.

Coverity-ID: 1490865
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
xen/common/domain.c