tools: Drop xc_cpuid_check() and bindings
authorAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 17 Jul 2017 12:38:03 +0000 (13:38 +0100)
committerWei Liu <wei.liu2@citrix.com>
Thu, 20 Jul 2017 16:35:52 +0000 (17:35 +0100)
commit73771b89fd9d89a23d5c7b760056fdaf94946be9
tree6a098bad5e4676ac20d1873df178648774084115
parent32e5bd5dcf6f45c2fc39d8d62b52b53d3e79ada7
tools: Drop xc_cpuid_check() and bindings

There are no current users which I can locate.  One piece of xend which didn't
move forwards into xl/libxl is this:

  #   Configure host CPUID consistency checks, which must be satisfied for this
  #   VM to be allowed to run on this host's processor type:
  #cpuid_check=[ '1:ecx=xxxxxxxxxxxxxxxxxxxxxxxxxx1xxxxx' ]
  # - Host must have VMX feature flag set

The implementation of xc_cpuid_check() is conceptually broken.  Dom0's view of
CPUID is not the approprite view to check, and will be wrong in the presence
of CPUID masking/faulting, and for HVM-based toolstack domains.

If it turns out that the functionality is required, it should be implemented
in terms of XEN_SYSCTL_get_cpuid_policy to use the proper CPUID view.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
tools/libxc/include/xenctrl.h
tools/libxc/xc_cpuid_x86.c
tools/ocaml/libs/xc/xenctrl.ml
tools/ocaml/libs/xc/xenctrl.mli
tools/ocaml/libs/xc/xenctrl_stubs.c
tools/python/xen/lowlevel/xc/xc.c