drm/vc4: simplify exit path of a failed allocation of dsi_connector
authorColin Ian King <colin.king@canonical.com>
Fri, 3 Feb 2017 19:56:24 +0000 (19:56 +0000)
committerpopcornmix <popcornmix@gmail.com>
Tue, 6 Feb 2018 12:37:56 +0000 (12:37 +0000)
commit6ec6021bc0671dbd9fda4a693f2ebb94b652031e
treef044312d8dd9cbf32feb2b21c5cc0d2f32fa752a
parent0e73c837e837aa98b9334f4b92da818997b8d377
drm/vc4: simplify exit path of a failed allocation of dsi_connector

If dsi_connector fails to allocate, the exit path via label 'fail'
checks if connector is null, which it always is, so the cleanup
that destroys connector is never going to be called.  Hence the
failure path can be more optimally performed by removing this
and just returning ERR_PTR(-ENOMEM).  This also removes the need
to initialize connector to NULL, and we can also remove ret too.

Detected by CoverityScan, CID#1399504 ("Logicall Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170203195624.7189-1-colin.king@canonical.com
(cherry picked from commit fce6a7bc22114c69b071bcf6fbfea2d07de6273c)
drivers/gpu/drm/vc4/vc4_dsi.c