llvm-D42262-jumpthreading-not-i1
authorLLVM Packaging Team <pkg-llvm-team@lists.alioth.debian.org>
Mon, 23 Mar 2020 10:59:23 +0000 (10:59 +0000)
committerGianfranco Costamagna <locutusofborg@debian.org>
Mon, 23 Mar 2020 10:59:23 +0000 (10:59 +0000)
commit6d6fa64265a09139fef416231e01d5ee25749452
tree159f2bb54190e786d32b9b27125ef087803df2d0
parent9f6fc4084b14ee276432ff3e8b67c960e679a5a9
llvm-D42262-jumpthreading-not-i1

commit 6a311a7a804831fea43cfb2f61322adcb407a1af
Author: Keno Fischer <keno@juliacomputing.com>
Date:   Thu Jan 18 15:57:05 2018 -0500

    [JumpThreading] Don't restrict cast-traversal to i1

    Summary:
    In D17663, JumpThreading learned to look trough simple cast instructions,
    but only if the source of those cast instructions was a phi/cmp i1
    (in an effort to limit compile time effects). I think this condition
    is too restrictive. For switches with limited value range, InstCombine
    will readily introduce an extra `trunc` instruction to a smaller
    integer type (e.g. from i8 to i2), leaving us in the somewhat perverse
    situation that jump-threading would work before running instcombine,
    but not after. Since instcombine produces this pattern, I think we
    need to consider it canonical and support it in JumpThreading.
    In general, for limiting recursion, I think the existing restriction
    to phi and cmp nodes should be sufficient to avoid looking through
    unprofitable chains of instructions.

    Reviewers: haicheng, gberry, bmakam, mcrosier

    Subscribers: llvm-commits

    Differential Revision: https://reviews.llvm.org/D42262

Gbp-Pq: Topic julia
Gbp-Pq: Name llvm-D42262-jumpthreading-not-i1.patch
lib/Transforms/Scalar/JumpThreading.cpp
test/Transforms/JumpThreading/basic.ll