drm/vc4: Account for interrupts in flight
authorStefan Schake <stschake@gmail.com>
Fri, 10 Nov 2017 01:05:06 +0000 (02:05 +0100)
committerpopcornmix <popcornmix@gmail.com>
Tue, 6 Feb 2018 12:37:56 +0000 (12:37 +0000)
commit6c7c57a5dc6b0923615137a8c42f0d6d889424f7
tree4d08315c52f0fd9f0699fe2d08a1894ef25166c9
parent29999ced4e97d3b1ae87e39b74e362cd6f048e29
drm/vc4: Account for interrupts in flight

Synchronously disable the IRQ to make the following cancel_work_sync
invocation effective.

An interrupt in flight could enqueue further overflow mem work. As we
free the binner BO immediately following vc4_irq_uninstall this caused
a NULL pointer dereference in the work callback vc4_overflow_mem_work.

Link: https://github.com/anholt/linux/issues/114
Signed-off-by: Stefan Schake <stschake@gmail.com>
Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.")
Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/1510275907-993-2-git-send-email-stschake@gmail.com
(cherry picked from commit 253696ccd613fbdaa5aba1de44c461a058e0a114)
drivers/gpu/drm/vc4/vc4_irq.c